Merged
Conversation
marcindsobczak
requested review from
LukaszRozmej,
MarekM25,
benaadams and
kamilchodola
Member
|
Why can't be changed in chainspec? |
Contributor
Author
|
It can, but starting arguments are easier to customize, that's a preference of Pari/Carlos to have it standarized as a CLI arg and don't touch genesis files |
rubo
approved these changes
Oct 15, 2025
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Member
|
I don't really like it, this kind of things lead to bugs... |
Contributor
|
Maybe just hide it from docs. Network id is actually not a consensus part, while genesis is about consensus, so not so bad. Can be in network config? |
Member
sure but I have a feeling this won't be the last |
Contributor
Author
|
For now it's needed only for bloatnet, so I chery-picked it to performance branch and converting PR to the draft. I would like to avoid bigger refactors just for the purpose of this simple adjustment - hiding it from docs and merging or keeping in a branch outside of master seems reasonable |
MarekM25
approved these changes
Oct 17, 2025
Member
|
I still think this should be formalized under |
MarekM25
reviewed
Oct 18, 2025
Contributor
MarekM25
left a comment
MarekM25
left a comment
There was a problem hiding this comment.
Cover this behaviour with tests and should be okay?
# src/Nethermind/Nethermind.Api/IInitConfig.cs # src/Nethermind/Nethermind.Api/InitConfig.cs
This reverts commit 7f25638.
…twork_id # Conflicts: # src/Nethermind/Nethermind.Api/IInitConfig.cs # src/Nethermind/Nethermind.Api/InitConfig.cs
benaadams
reviewed
Nov 5, 2025
benaadams
approved these changes
Nov 5, 2025
kamilchodola
added a commit
that referenced
this pull request
Nov 9, 2025
* Add more logging in MultiSyncModeSelector (#9616) * Add more logging * fix for seq * feat: Add configurable EIP-2935 ring buffer size (#9611) * Blockchain Engine Tests support (#9394) * initial commit * fix normal blockchain tests * tidy * restore disposes * comment out BALs * fix var declaration * don't set basefeepergas if null * use network from genesis in blockchain test * update blockchain test base * add tracer to blockchain tests runner * tidy * tidy * add genesis processing timeout * check for null head block * try undo some changes * detect failure to process genesis * check removal is error * add back checks for genesis spec * only add noenginerequeststracker in tests * comment sealed block check * try remove timeout * only configure merge for engine tests * fix merge module init * add back timeout and remove sealer * await new payloads * use reflection for engine rpc method calling --------- Co-authored-by: Marc Harvey-Hill <10379486+Marchhill@users.noreply.github.com> * use zero address when from address not specified in rpc calls (#9578) * use zero address for null values * small test * fix proof rpc * fix test and add more changes * Allow serving snap requests for more than 128 blocks (#9602) * Initial plan * Add SnapServingMaxDepth configuration and update LastNStateRootTracker Co-authored-by: tanishqjasoria <11698398+tanishqjasoria@users.noreply.github.com> * Add clarifying comments for configuration changes Co-authored-by: tanishqjasoria <11698398+tanishqjasoria@users.noreply.github.com> * Get reorgDepth from config instead of hardcoding in test Co-authored-by: LukaszRozmej <12445221+LukaszRozmej@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tanishqjasoria <11698398+tanishqjasoria@users.noreply.github.com> Co-authored-by: Tanishq Jasoria <jasoriatanishq@gmail.com> Co-authored-by: LukaszRozmej <12445221+LukaszRozmej@users.noreply.github.com> * Remove console log from FileTestsSource (#9622) Removed console log for loading test file. * Correct docs value for Blocks.BlockProductionMaxTxKilobytes (#9620) * Update OP Superchain chains (#9629) Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> * Auto-update fast sync settings (#9628) Co-authored-by: rubo <rubo@users.noreply.github.com> * feat: write AckMessage directly to IByteBuffer without temp array (#9623) * Optimize Ripemd (#9627) * Allow precompile cache to be switched off by config (#9633) * Mainnet Osaka, BPO1, BPO2 forks (#9615) * Change rlp limits and add logs (#9631) * log rlp guard messages * Adding stack trace * Increase receipts limit to 1024 * fix for stack trace * try fix multiline * fix * whitespace * try fix * More logs and potential fixes * log fix * Revert "More logs and potential fixes"This reverts commit ec71c87.# Conflicts:# src/Nethermind/Nethermind.Network/MessageSerializationService.csRevert "log fix"This reverts commit b3b1f5f. Revert "More logs and potential fixes" This reverts commit ec71c87. * try weird fix * Revert "try weird fix" This reverts commit 0bdfb3d. * revert packages.json * simplify log * Don't abbreviate ForkchoiceStateV1 hashes * revert spammy ForkchoiceStateV1 * Fix missed dispose on StorageRange in ProgressTracker * fix test * Optimise CALL by throwing stack underflow earlier (#9581) * fail fast * add unit tests --------- Co-authored-by: Marc Harvey-Hill <10379486+Marchhill@users.noreply.github.com> * Optimize BN254Pairing call (#9621) * Optimize BN254Pairing call * Don't modify input * Skip locals * Tweak inlining * Update src/Nethermind/Nethermind.Evm.Precompiles/BN254.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> * Less fixed * Optimize * Optimize * formatting * formatting * Tidy * Use constants * Feedback * Skip init * Faster * More skip init * Make mul ReadOnlySpan, add comments * Simplify * Skip locals * Ruben making me work for it * More working for it * Still working for it * Update benchmarks * Apply suggestions from code review Co-authored-by: Marc <Marchhill@users.noreply.github.com> * Feedback --------- Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> Co-authored-by: Marc <Marchhill@users.noreply.github.com> * Update OP Superchain chains (#9643) Co-authored-by: LukaszRozmej <LukaszRozmej@users.noreply.github.com> * Log/decrease noise (#9642) * decrease Ethash cache miss log * Decrease block downloader invalid bloc log * Update X handle (#9634) * Better logs on invalid orphan (#9641) * Try fixing world wrong block * not this, so keep validating Withdrawals * Update all op chain configs (#9645) * update configs * update all configs * Add `NetworkId` flag to `InitConfig` (#9476) * add flag with networkId * cosmetic * Update src/Nethermind/Nethermind.Api/IInitConfig.cs Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> * fix * # Conflicts: # src/Nethermind/Nethermind.Api/IInitConfig.cs # src/Nethermind/Nethermind.Api/InitConfig.cs * Revert "# Conflicts:" This reverts commit 7f25638. * postmerge fix * Apply suggestion from @benaadams --------- Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: Ben {chmark} Adams <thundercat@illyriad.co.uk> * Revert "HACK: enable in fusaka" This reverts commit 7cfad14. * HACK: enable in pectra --------- Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> Co-authored-by: Daniil Ankushin <ankushin.daniil42@gmail.com> Co-authored-by: Marc <Marchhill@users.noreply.github.com> Co-authored-by: Marc Harvey-Hill <10379486+Marchhill@users.noreply.github.com> Co-authored-by: Tanishq Jasoria <jasoriatanishq@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: tanishqjasoria <11698398+tanishqjasoria@users.noreply.github.com> Co-authored-by: LukaszRozmej <12445221+LukaszRozmej@users.noreply.github.com> Co-authored-by: Ben {chmark} Adams <thundercat@illyriad.co.uk> Co-authored-by: core-repository-dispatch-app[bot] <173070810+core-repository-dispatch-app[bot]@users.noreply.github.com> Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> Co-authored-by: rubo <rubo@users.noreply.github.com> Co-authored-by: VolodymyrBg <aqdrgg19@gmail.com> Co-authored-by: LukaszRozmej <LukaszRozmej@users.noreply.github.com> Co-authored-by: Marcin Sobczak <77129288+marcindsobczak@users.noreply.github.com> Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
NetworkIdflag toInitConfigwhich is needed for bloatnetTypes of changes
What types of changes does your code introduce?
Testing
Requires testing